gh-140454: Normalize the JIT stencils filename on Linux to avoid mismatches between the Makefile and the generator #140823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….unknown-linux-gnu.h (as expected by Makefile) This avoids needless JIT recompilation during make install.
hroncok
requested review from
brandtbucher,
diegorusso and
savannahostrowski
as code owners
hroncok
requested review from
AA-Turner,
corona10,
emmatyping and
erlend-aasland
as code owners
savannahostrowski
approved these changes
Nov 4, 2025
Member
savannahostrowski
left a comment
savannahostrowski
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks for investigating this and putting up the PR!
hroncok
changed the title
hroncok
changed the title
Contributor
Author
|
I renamed the PR to match the reality after the fixups. It's still a bit mouthful, feel free to suggest a better commit subject. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids needless JIT recompilation during make install.
make install#140454